Re: if_link_state_change() patch for review

From: Andre Oppermann (andre_at_freebsd.org)
Date: 04/19/05

  • Next message: Gleb Smirnoff: "Re: if_link_state_change() patch for review" 
    Date: Tue, 19 Apr 2005 11:49:36 +0200
To: Gleb Smirnoff <glebius@FreeBSD.org>

    Gleb Smirnoff wrote:
    >
    > Dear networkers,
    >
    > we are working on fixing LORs in if_link_state_change() path, and
    > adding possibility to call if_link_state_change() pseudorecursively,
    > when link of interface depends on link of the other.
    >
    > I'm posting this patch for wider review. An important point about it
    > is that, if several link events occur VERY quickly, only the last one
    > will be processed. I don't know of any software that will be broken by
    > such behavoir. If you know some, please tell me.

    I assume this is per interface and not for all interfaces together.

    You have to be careful here indeed. If the link is rapidly flapping
    then you only want to report changes in status. For example when
    it going down, up, down and all these events got queued it doesn't
    make sense to report down->down. This could indeed confuse some
    tools and isn't very useful. Either you check the first event vs.
    the last one if there is a change in state or you just take the events
    as trigger to have a look at the interface status when the ithread
    runs. There however you'd have to track the previous state to detect
    changes. 

    -- 
Andre
_______________________________________________
freebsd-net@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-net
To unsubscribe, send any mail to "freebsd-net-unsubscribe@freebsd.org"
  • Next message: Gleb Smirnoff: "Re: if_link_state_change() patch for review"

    Relevant Pages