Re: if_tap unaligned access problem

From: Sten Spans (sten_at_blinkenlights.nl)
Date: 05/02/05

  • Next message: John-Mark Gurney: "Re: gigabit ethernet (copper/fibre)" 
    Date: Mon, 2 May 2005 21:20:01 +0200 (CEST)
To: Maksim Yevmenkin <maksim.yevmenkin@savvis.net>

    On Mon, 2 May 2005, Maksim Yevmenkin wrote:

    > Hello,
    >
    >>>>>>> i think we have few options here:
    >>>>>>>
    >>>>>>> 1) revert back original tapwrite function that was changed in v. 1.48
    >>>>>>> and set offset to 2 bytes in top mbuf
    >>>>>>>
    >>>>>>> 2) change current version of tapwrite so it would m_prepend and
    >>>>>>> m_pullup mbuf after m_uiotombuf
    >>>>>>>
    >>>>>>> 3) change m_uiotombuf to accept one more parameter - mbuf offset at
    >>>>>>> which data should be copied. there are not that many users of
    >>>>>>> m_uiotombuf
    >>>
    >>> please find and review the attached patch (untested) that implements
    >>> option (3) above.
    >
    > any objections to the attached (revised) patch? can i commit it?

    I've tested the code on fbsd-current alpha and it fixes
    the crash. I was kinda waiting for somebody to test it on
    sparc, but that's taking a few days longer than expected.
    I may run a test on one of my own sparcs to verify
    the results.

    That said, the issue seems pretty clear-cut, as is the solution. 

    -- 
Sten Spans
"There is a crack in everything, that's how the light gets in."
Leonard Cohen - Anthem
_______________________________________________
freebsd-net@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-net
To unsubscribe, send any mail to "freebsd-net-unsubscribe@freebsd.org"
  • Next message: John-Mark Gurney: "Re: gigabit ethernet (copper/fibre)"

    Relevant Pages