Re: kern/83011: nge vlans broken

From: Yuriy N. Shkandybin (jura_at_networks.ru)
Date: 07/14/05

  • Next message: Danny Braniss: "Re: tcp troughput weirdness" 
    To: "Ragnar Lonn" <raglon@packetfront.com>
Date: Thu, 14 Jul 2005 12:26:53 +0400

    No, this is 6 and CURRENT.

    For 5 if_nge.c diffs 1.72 and 1.73 should be applied.
    Otherwise you'll get crash.

    Jura

    ----- Original Message -----
    From: "Ragnar Lonn" <raglon@packetfront.com>
    To: "Yuriy N. Shkandybin" <jura@networks.ru>
    Cc: <freebsd-net@freebsd.org>
    Sent: 14 èþëÿ 2005 ã. 11:55
    Subject: Re: kern/83011: nge vlans broken

    > This is in 5.x, right? I can't find this code in 4.11 at least.
    > Does that mean that ngeth VLAN support is broken in 5.x (without the
    > patch)?
    >
    > Regards,
    >
    > /Ragnar
    >
    > Yuriy N. Shkandybin wrote:
    >
    >> I've invistigated that m_head mbuf doesn't have M_VLANTAG when performing
    >> VLAN_OUTPUT()
    >>
    >> next diff for /usr/src/sys/net/if_vlan_var.h make it work:
    >> --- 1.h Fri Jul 8 17:34:31 2005
    >> +++ if_vlan_var.h Fri Jul 8 17:35:53 2005
    >> @@ -111,7 +111,7 @@
    >> } while (0)
    >>
    >> #define VLAN_OUTPUT_TAG(_ifp, _m) \
    >> - ((_m)->m_flags & M_VLANTAG ? \
    >> + ((_ifp)->if_nvlans != 0 ? \
    >> m_tag_locate((_m), MTAG_VLAN, MTAG_VLAN_TAG, NULL) : NULL)
    >> #define VLAN_TAG_VALUE(_mt) (*(u_int *)((_mt)+1))
    >> #endif /* _KERNEL */
    >>
    >>
    >> Actually this is partial backout ru@ commit
    >> http://www.freebsd.org/cgi/cvsweb.cgi/src/sys/net/if_vlan_var.h.diff?r1=1.20&r2=1.21&f=h
    >>
    >> Since it's not adressed to if_nge itself, so it's possible same problems
    >> for another interfaces.
    >>
    >> Jura
    >>
    >>
    >> _______________________________________________
    >> freebsd-net@freebsd.org mailing list
    >> http://lists.freebsd.org/mailman/listinfo/freebsd-net
    >> To unsubscribe, send any mail to "freebsd-net-unsubscribe@freebsd.org"
    >
    >
    >

    _______________________________________________
    freebsd-net@freebsd.org mailing list
    http://lists.freebsd.org/mailman/listinfo/freebsd-net
    To unsubscribe, send any mail to "freebsd-net-unsubscribe@freebsd.org"

  • Next message: Danny Braniss: "Re: tcp troughput weirdness"