Re: AltQ + ng_iface

From: Julian Elischer (julian_at_elischer.org)
Date: 07/30/05

  • Next message: Daniel O'Connor: "Re: AltQ + ng_iface" 
    Date: Sat, 30 Jul 2005 12:38:32 -0700
To: "Daniel O'Connor" <doconnor@gsoft.com.au>

    Daniel O'Connor wrote:
    > On Saturday 30 July 2005 19:00, Daniel O'Connor wrote:
    >
    >>I'll try my hand at the ng_iface ALTQ patch.
    >
    >
    > Here's what I have so far..
    >
    > http://www.dons.net.au/~darius/ng_iface-altq.diff
    >
    > Haven't done much testing yet though.

    small comments so far..

    mbuf tags have "families" so that differetn modules can use
    the same ID numbers and not clash.
    here is a netgraph family for tags, using the netgraph cookies.
    It's been a while since I looked at it but if you are using mbuf
    tags in netgraph you should check out the netgraph tag facilities.

    If you queue data to be send over a hook you must have the data hold a
    reference on the hook to ensure that the hook is not removed while your
    packet is in teh queue. Similarly either the packet holds a reference
    on teh node as well, or the node must lock it's queue and remove all
    packets when shut down.

    I see that you don't actually decid eon what hook will be used until later so
    teh reference to teh hook needn't be done, but you haven't added any code to
    either hold a reference on the node, or to clean the queue on shutdown.
    (or is that done automatically by some iface base code that is called
    during shutdown).

    The calling code must always have a reference on the node to ensure that
    it is not removed while it is running in it. This is sometimes
    done automatically. This is why there is an ng_callout facility to ensure
    that the locking andreferences are done automatically and correctly.

    I would also want to have the altq optional..
    in other words I'd want a control message to ng_iface that could make it
    act as before.

    >

    _______________________________________________
    freebsd-net@freebsd.org mailing list
    http://lists.freebsd.org/mailman/listinfo/freebsd-net
    To unsubscribe, send any mail to "freebsd-net-unsubscribe@freebsd.org"

  • Next message: Daniel O'Connor: "Re: AltQ + ng_iface"

    Relevant Pages

    • Re: GEDOM as a database format
      ... reference a person's name, address during a particular year, and the date ... and how those tags can generate both display text ... The problem with xml as I see is it is in its origins of document definition. ... As to the lack of a working genealogical xml scheme, I sympaphize, but I doubt that there can be one. ...
      (soc.genealogy.computing)
    • [PATCH] DocBook/HTML: correction of recursive A tags in HTML output
      ... The malformed HTML was generated after switch to XSLTPROC ... from SGML tools. ... The reference title ... is converted into two recursive tags ...
      (Linux-Kernel)
    • Re: h1, h2 and search engines
      ... I think I got it from a reference you gave. ... the analysis done on that site was that there were no tags. ... > nor will they help your site placement or ranking in a search engine. ...
      (microsoft.public.frontpage.client)
    • Re: Reference page cast not working
      ... The VS 2005 conversion tool did not properly convert my explicit @ ... Reference directive tags on the .ascx page, ... control of that type actually appears as a static control on the page. ...
      (microsoft.public.dotnet.languages.csharp)
    • AxWebBrowser and System.Drawing.Bitmap
      ... the appropriate app action. ... easy is doing the same thing for tags. ... How can I hook into img tag src parsing, so that I can intercept, say, ... Prev by Date: ...
      (microsoft.public.dotnet.framework.interop)