Some missing splnet() in key.c
From: VANHULLEBUS Yvan (yvan.vanhullebus_at_netasq.com)
Date: 08/17/05
- Previous message: Heinrich Rebehn: "2. try: nfsd send error -1"
- Next in thread: VANHULLEBUS Yvan: "Re: Some missing splnet() in key.c"
- Reply: VANHULLEBUS Yvan: "Re: Some missing splnet() in key.c"
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]
Date: Wed, 17 Aug 2005 20:23:49 +0200 To: freebsd-net@freebsd.org
Hi all.
A few months ago, I reported some missing splnet() in key.c to
snap-users@kame.net. I found them by tracking some random and strange
problems, which are more likely to happen when running on a "slow"
CPU, when having some heavy PFKey activity and when having high IPSec
traffic.
The attached patch (made against FreeBSD6 version, but should be easy
to port to other versions) fixes at least most splnet problems (well,
at least, I didn't have any more report for customers which use the
latest version including all those locks....).
Please note that mixing this patch and the FreeBSD NAT-T patch
available on ipsec-tools web site will have a possible dead lock in
key_add(), when handling NAT-T extensions (Manu: check that for
NetBSD, there is probably the same code !).
I'll update quickly FreeBSD6 NAT-T patchset on ipsec-tools web site if
this patch is commited on FreeBSD6 source.
Yvan.
-- NETASQ - Secure Internet Connectivity http://www.netasq.com
- application/x-pkcs7-signature attachment: smime.p7s
- Previous message: Heinrich Rebehn: "2. try: nfsd send error -1"
- Next in thread: VANHULLEBUS Yvan: "Re: Some missing splnet() in key.c"
- Reply: VANHULLEBUS Yvan: "Re: Some missing splnet() in key.c"
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]
Relevant Pages
|
|
