Re: [Fwd: assigning an address to ng_fec(4) iface causes panic]
From: Maksim Yevmenkin (maksim.yevmenkin_at_gmail.com)
Date: 08/23/05
- Previous message: Pieter de Boer: "Re: odd tcpdump output w/ 6.0-BETA2 ..."
- In reply to: Brooks Davis: "Re: [Fwd: assigning an address to ng_fec(4) iface causes panic]"
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]
Date: Tue, 23 Aug 2005 11:33:10 -0700 To: Brooks Davis <brooks@one-eyed-alien.net>
On 8/23/05, Brooks Davis <brooks@one-eyed-alien.net> wrote:
> On Tue, Aug 23, 2005 at 10:09:06AM -0700, Maksim Yevmenkin wrote:
> > Hello,
> >
> > please try the attached patch.
> >
> > > >Description:
> > > assigning an address to ng_fec(4) iface causes panic
> > > during dumping to dumpdev another panic occurs preventing to identify the source of the first panic and having the crash dump
> > >
> > > ng_iface creation sequence:
> > > mkpeer fec dummy fec
> > > msg fec0: add_iface "em0"
> > > msg fec0: add_iface "em1"
> > > msg fec0: set_mode_mac
> > >
>
> > --- ng_fec.c.orig Mon Aug 22 11:42:51 2005
> > +++ ng_fec.c Tue Aug 23 10:05:23 2005
> > @@ -544,8 +544,8 @@
> > struct ifnet *ifp, *bifp;
> > struct ng_fec_portlist *p;
> >
> > - ifp = arg;
> > - priv = ifp->if_softc;
> > + priv = arg;
> > + ifp = priv->ifp;
> > b = &priv->fec_bundle;
> >
> > if (b->fec_ifcnt == 1 || b->fec_ifcnt == 3) {
>
> This isn't quite sufficent. You also should change the ng_fec_init(ifp)
> call on line 718 to ng_fec_init(ifp->if_softc). If that work's I'll
> commit it.
oops... i missed this. thanks for catching this! i do not have
hardware to test it :) i have attached updated path. if anyone could
please test it and confirm that it works then feel free to commit it
(or let me know and i can commit it myself :)
> I've got to say this calling convention is really stupid. I'm
> really tempted to change ifp->if_init() to take a struct ifnet * even
> though it means an API change and a tree sweep.
sounds good to me.
thanks,
max
_______________________________________________
freebsd-net@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-net
To unsubscribe, send any mail to "freebsd-net-unsubscribe@freebsd.org"
- text/plain attachment: ng_fec.c.diff.txt
- Previous message: Pieter de Boer: "Re: odd tcpdump output w/ 6.0-BETA2 ..."
- In reply to: Brooks Davis: "Re: [Fwd: assigning an address to ng_fec(4) iface causes panic]"
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]
Relevant Pages
|
