Re: Fixed Dest Port for traceroute(8)

From: Maxim Konovalov (maxim_at_macomnet.ru)
Date: 09/26/05

  • Next message: FreeBSD bugmaster: "Current problem reports assigned to you"
    Date: Mon, 26 Sep 2005 12:14:14 +0400 (MSD)
    To: "Crist J. Clark" <cjc@freebsd.org>
    
    

    [...]
    > Index: traceroute.c
    > ===================================================================
    > RCS file: /ncvs/freebsd/src/contrib/traceroute/traceroute.c,v
    > retrieving revision 1.27
    > diff -u -r1.27 traceroute.c
    > --- traceroute.c 26 Aug 2005 18:08:24 -0000 1.27
    > +++ traceroute.c 23 Sep 2005 17:47:45 -0000
    [...]
    > @@ -521,13 +522,17 @@
    > prog = argv[0];
    >
    > opterr = 0;
    > - while ((op = getopt(argc, argv, "dFInrSvxf:g:i:M:m:P:p:q:s:t:w:z:")) != EOF)
    > + while ((op = getopt(argc, argv, "edFInrSvxf:g:i:M:m:P:p:q:s:t:w:z:")) != EOF)

    Better to keep the keys sorted alphabetically. I.e. "deFI..". Need
    to update usage() as well.

    -- 
    Maxim Konovalov
    _______________________________________________
    freebsd-net@freebsd.org mailing list
    http://lists.freebsd.org/mailman/listinfo/freebsd-net
    To unsubscribe, send any mail to "freebsd-net-unsubscribe@freebsd.org"
    

  • Next message: FreeBSD bugmaster: "Current problem reports assigned to you"

    Relevant Pages

    • Re: HEADS UP: socket and pcb reference changes entering tree today
      ... On Sun, 21 May 2006, 19:04+0100, Robert Watson wrote: ... On Sun, 21 May 2006, Maxim Konovalov wrote: ... remaining bugs in the raw socket code elsewhere also, ... retrieving revision 1.161 ...
      (freebsd-current)
    • Re: HEADS UP: socket and pcb reference changes entering tree today
      ... On Sun, 21 May 2006, Maxim Konovalov wrote: ... This patch looks good to me. ... The races here are quite minor in practice, involving simultaneous changes of connection state between different threads acting on the same socket, but also the sort of thing that would be almost impossible to debug if it occurred in practice :-). ... retrieving revision 1.161 ...
      (freebsd-current)