Re: Race condition in ip6_getpmtu (actually gif)?

On Mon, 27 Feb 2006 14:03:01 -0600,
Craig Boston <craig@xxxxxxxxxxxxxx> said:

Attached is a quick hack to protect the cached route with a mutex. A
better fix with less overhead would be to allocate the route in a local
variable on the stack, and only copy it to the softc if route caching is
enabled. I'll run for a couple weeks with the patch and file a PR if
that fixes it.

I guess this problem was fixed with the following changes:

http://www.jp.freebsd.org/cgi/cvsweb.cgi/src/sys/net/if_gif.c.diff?r1=1.57&r2=1.58
http://www.freebsd.org/cgi/cvsweb.cgi/src/sys/netinet6/in6_gif.c.diff?r1=1.23&r2=1.24

Yes, it was. I saw the changes in those files when I attempted to
re-merge my patch after a cvsup. I've currently been running with no
panics for 12 days with rev 1.52.2.4 of if_gif.c and rev 1.22.2.2 of
in6_gif.c.

Okay, thanks for the confirmation.

JINMEI, Tatuya
Communication Platform Lab.
Corporate R&D Center, Toshiba Corp.
jinmei@xxxxxxxxxxxxxxxxxxxxx
_______________________________________________
freebsd-net@xxxxxxxxxxx mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-net
To unsubscribe, send any mail to "freebsd-net-unsubscribe@xxxxxxxxxxx"

Relevant Pages

  • Re: [PATCH resubmit] do_mount: reduce stack consumption
    ... Hence stack frame size of do_mount is directly influenced by those two ... performance impact for the user to allocate the structs. ... send the line "unsubscribe linux-kernel" in ...
    (Linux-Kernel)
  • Re: Race condition in ip6_getpmtu (actually gif)?
    ... variable on the stack, and only copy it to the softc if route caching is ... re-merge my patch after a cvsup. ...
    (freebsd-net)
  • Re: Unexpected multicast IPv4 socket behavior
    ... Default route set, src INADDR_ANY: ... src bindto interface address: ... There's no way for the stack to know which interface to originate the traffic from in the case where there is no default route, and no IP layer source information elsewhere in the stack. ... the use of multicast requires that you create a socket and bind to the interface where you wish to send and receive the channel. ...
    (freebsd-net)
  • Re: why are alias names a bad idea?
    ... The manual provides some examples where the /GATYEWAY is given as a host ... to an IP address is done at one point in time (likely during stack ... If the default route changes from one router to another, ...
    (comp.os.vms)
  • Re: Unexpected multicast IPv4 socket behavior
    ... Default route set, src INADDR_ANY: ... src bindto interface address: ... There's no way for the stack to know which interface to originate the traffic from in the case where there is no default route, and no IP layer source information elsewhere in the stack. ... the use of multicast requires that you create a socket and bind to the interface where you wish to send and receive the channel. ...
    (freebsd-net)