Re: kern/110720: [net] [patch] support for interface descriptions

On Sat, Mar 24, 2007 at 11:30:44AM +0100, Andre Oppermann wrote:

Harti Brandt wrote:
Nice feature, although it would be nice to align the maximum length with
IF-MIB::ifDescr (255 byte + \0). Also I suppose that the field more
naturally fits into struct if_data (see net/if.h) given the comment for
that struct:

/*
* Structure describing information about an interface
* which may be of interest to management entities.
*/

The string array should most likely not be part of struct ifnet as that
would bloat it quite a bit. If it is in there it should be at the end
of the struct to avoid cache line busting effects.

Also vote for this. And is it possible to make it a pointer instead
of array? The bloat would be minimal for system with tons of interfaces,
think about large pptp or pppoe server or similar that never would
utilize arrays.

Eugene Grosbein
_______________________________________________
freebsd-net@xxxxxxxxxxx mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-net
To unsubscribe, send any mail to "freebsd-net-unsubscribe@xxxxxxxxxxx"

Relevant Pages

  • [Patch 5/8] taskstats interface
    ... separate out taskstats interface from delay accounting completely including ... Create a "taskstats" interface based on generic netlink ... * The struct is versioned. ...
    (Linux-Kernel)
  • [PATCH] usbmon: add binary interface
    ... USB records are stored in a liked list, alike current text interface implementation, so most code is shared from binary and text interface. ... unsigned int cmd, unsigned long arg) ... struct urb *urb, char ev_type) ...
    (Linux-Kernel)
  • [Patch 5/8] taskstats interface
    ... separate out taskstats interface from delay accounting completely including ... Create a "taskstats" interface based on generic netlink ... +Linux task defined by struct task_struct. ...
    (Linux-Kernel)
  • [updated] [Patch 5/8] taskstats interface
    ... separate out taskstats interface from delay accounting completely including ... Create a "taskstats" interface based on generic netlink ... +Linux task defined by struct task_struct. ...
    (Linux-Kernel)
  • Re: Conformant IDL array trouble
    ... I'm trying to send an array of structs ... array inside the struct gets marshalled. ... I'm not trying to be automation compatible ... and I've registered and built the proxy/stub for the interface. ...
    (microsoft.public.win32.programmer.ole)