MFC of ether_input() changes

Hi,

Does anyone want to see these changes MFCed, or otherwise object to such an MFC?
The introduction of M_PROMISC did the following:

* Drop frames immediately if the interface is not marked IFF_UP.
* Always trim off the frame checksum if present.
* Always use M_VLANTAG in preference to passing 802.1Q frames
to consumers.
* Use __func__ consistently for KASSERT().
* Use the M_PROMISC flag to detect situations where ether_input()
may reenter itself on the same call graph with the same mbuf which
was promiscuously received on behalf of subsystems such as
netgraph, carp, and vlan.
* 802.1P frames (that is, VLAN frames with an ID of 0) will now be
passed to layer 3 input paths.
* Deal with the special case for CARP in a sane way.

For end users the main change of interest will be the ability for FreeBSD to receive 802.1p frames, even if it doesn't do anything with the priority fields right now.

If I hear 'yeses' I will try to MFC this as time permits.

Regards,
BMS
_______________________________________________
freebsd-net@xxxxxxxxxxx mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-net
To unsubscribe, send any mail to "freebsd-net-unsubscribe@xxxxxxxxxxx"

Relevant Pages

  • Re: MFC of ether_input() changes
    ... Bruce M Simpson wrote: ... Does anyone want to see these changes MFCed, or otherwise object to such an MFC? ... Drop frames immediately if the interface is not marked IFF_UP. ...
    (freebsd-net)
  • MoveWindow does not move window on Vista.
    ... I am experiencing a strange problem on Vista. ... I have a bunch of windows, frames with splitters with childframes etc. ... On one level there is a MFC CFrameWnd hosting a MFC CDialog as a ... On XP the dialog gets it's WM_SIZE and the GUI looks like it should. ...
    (microsoft.public.win32.programmer.ui)
  • Frame Displays?
    ... I am trying to find a solution in MFC to impliment 'frames' on a dialog, ... I have one dialog that will need to contain several major sets of edits, ...
    (microsoft.public.vc.mfc)
  • Re: MFC of ether_input() changes
    ... Drop frames immediately if the interface is not marked IFF_UP. ... may reenter itself on the same call graph with the same mbuf which ... Deal with the special case for CARP in a sane way. ... If I hear 'yeses' I will try to MFC this as time permits. ...
    (freebsd-net)
  • Re: Problems with BCE network adapter (Dell PE2950)
    ... After applying both David and Sephe's patches I have yet to get a system in a state where it is stable with jumbo frames enabled, the systems crash almost immediately after the switch changes the port state from LEARNING to FORWARDING. ... The next test was to try the kernel with BCE_DEBUG and with the following extra patch (so that the driver does not jump to the breakpoint when an unexpected mbuf is found in the rx buffer). ...
    (freebsd-net)