Re: driver packet coalesce



Jack Vogel wrote:
On 5/31/07, Wilkinson, Alex <alex.wilkinson@xxxxxxxxxxxxxxxxxxx> wrote:
0n Wed, May 30, 2007 at 04:45:05PM -0700, Jack Vogel wrote:

> Does any driver do this now? And if a driver were to coalesce
> packets and send something up the stack that violates mss
> will it barf?

erm, what is meant by "coalesce" ?

combining packets before sending to the stack, aka LRO.

Yup - the firmware for the card's LRO engine would have to know not to coalesce packets not destined for the local host. I speculate many cards are not smart enough to do this, and LRO is an all-or-nothing proposition, as it's a technology designed to optimize for hosts, not routers; see recent discussions/slanging matches on end2end.

At the moment there is no central place where we track all layer 2 addresses for which traffic should be delivered locally. This would logically belong in struct ifnet, and clients e.g. CARP would have to be taught to add their layer 2 endpoint addresses there.

It seems acceptable to disable LRO if bridging is on and document this behaviour.

BMS
_______________________________________________
freebsd-net@xxxxxxxxxxx mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-net
To unsubscribe, send any mail to "freebsd-net-unsubscribe@xxxxxxxxxxx"



Relevant Pages

  • Re: driver packet coalesce
    ... And if a driver were to coalesce ... >>> packets and send something up the stack that violates mss ... No, LRO. ...
    (freebsd-net)
  • Re: driver packet coalesce
    ... I guess it would only be able to coalesce TCP packets that are adjacent in the same session. ... are a number of obvious and non-obvious interaction issues with LRO ... The LRO implementation (in the driver) has to be aware of all these ... issues and how the TCP stack treats them. ...
    (freebsd-net)
  • Re: Bugcheck D1 in NDIS-WDM driver
    ... processed more than 200 packets. ... When I use the verifier to further test this driver, ... If a kernel debugger is available get the stack backtrace. ... FOLLOWUP_NAME: MachineOwner ...
    (microsoft.public.development.device.drivers)
  • Re: driver packet coalesce
    ... And if a driver were to coalesce ... able to coalesce TCP packets that are adjacent in the same session. ...
    (freebsd-net)
  • Re: Bugcheck D1 in NDIS-WDM driver
    ... If these problems happen only when you have your driver loaded, ... > processed more than 200 packets. ... None of the stack traces has an entry for ... > FOLLOWUP_NAME: MachineOwner ...
    (microsoft.public.development.device.drivers)