Re: QinQ



Jon,

Thanks for the patch.

Jon Otterholm wrote:
I was wondering about the possibility of adding support for QinQ
("Double tagged frames" / "Nested vlans"). Attached is a patch against
-STABLE to add this support. I have not tested this but was told it
should work.

Would it be possible to get this into CURRENT?

In the 7.x train, I made some changes to always decode the VLAN tags and embed the information in the mbuf header. I did this to support 802.1p quality-of-service in the stack - VLAN 0 frames mean 'the whole subnet, not its vlan', and previously the stack just ignored these.

I can't remember off the top of my head if I merged this to 6.x - it means the patch herein may not even be needed, unless you need to do demux of vlan tags to arbitrary depth, something I think is best left to netgraph.

What I can tell you is that if you look at the comments in if_ethersubr.c, I left q-in-q as a possible todo item. I don't use it myself - however - the same approach might be considered for cards which have q-in-q support in their hardware tag/queue processing.

Kip Macy may be able to advise further - I understand the newer 10gbps cards are quite programmable in this respect.

However I believe it means we may not need to apply vlan(4)'s notion of having to call if_promisc() if the card already knows to supply the stack with frames for VLAN 'foo', i.e. if VLAN 'bar' is nested in 'foo'. Promiscuous mode is best avoided particularly with high rates of packets-per-second.

regards,
BMS
_______________________________________________
freebsd-net@xxxxxxxxxxx mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-net
To unsubscribe, send any mail to "freebsd-net-unsubscribe@xxxxxxxxxxx"



Relevant Pages

  • [2.6.10] PCMCIA/CardBus Wifi Card Problem
    ... I tried to build a configuration that was working but I didn't succeed. ... # Firmware Drivers ... # ACPI Support ... # Obsolete Wireless cards support ...
    (Linux-Kernel)
  • Re: 2.4.32 Oops in scsi_dispatch_cmd
    ... >> The tar process is run from a backup scripts that mounts an IDE ... As I said, the IDE drive was on an ATA RAID card at first, visible to ... # Loadable module support ... # Passive ISDN cards ...
    (Linux-Kernel)
  • Re: 2.6.17-rc5-mm2
    ... Usually sshing into the machine and compiling the kernel is enough. ... # ACPI Support ... # Infrared-port device drivers ... # Wireless 802.11 Frequency Hopping cards support ...
    (Linux-Kernel)
  • Crashes wuth Tyan S2892
    ... Kernel panic - not syncing: ... # ACPI Support ... # AX.25 network device drivers ... # Wireless 802.11 Frequency Hopping cards support ...
    (Linux-Kernel)
  • 2.6.12.3 Kernel Oops using ISDN capi (c2faxsend)
    ... The ISDN Card installed in the Server is a AVM B1 4.0 PCI ... # ACPI Support ... # Device Drivers ... # Active Eicon DIVA Server cards ...
    (Linux-Kernel)