Re: tcp md5 checksums broken in 7.0-beta3



Bjoern A. Zeeb wrote:
I'll try to find your bug the next days (in case you find anything let
me know).

At the very least, this will be necessary:

--- tcp_subr.c~ 2007-11-28 01:14:46.000000000 +0000
+++ tcp_subr.c 2007-11-28 01:14:46.000000000 +0000
@@ -1948,7 +1948,7 @@
/*
* Step 4: Update MD5 hash with shared secret.
*/
- MD5Update(&ctx, _KEYBUF(sav->key_auth), _KEYLEN(sav->key_auth));
+ MD5Update(&ctx, sav->key_auth->key_data, _KEYLEN(sav->key_auth));
MD5Final(buf, &ctx);

key_sa_recordxfer(sav, m);

But it doesn't fix the problem.

Nick
_______________________________________________
freebsd-net@xxxxxxxxxxx mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-net
To unsubscribe, send any mail to "freebsd-net-unsubscribe@xxxxxxxxxxx"



Relevant Pages

  • Re: tcp md5 checksums broken in 7.0-beta3
    ... On Wed, 28 Nov 2007, Bjoern A. Zeeb wrote: ... Update MD5 hash with shared secret. ... But it doesn't fix the problem. ...
    (freebsd-net)
  • Re: [PATCH] if_sk(4) rx/tx "hangs"
    ... Bjoern A. Zeeb wrote: ... > that's it but I had been to lazy to tell you the whole dd story in te ... I have this exact model in my work computer. ...
    (freebsd-current)
  • Re: LOR + panic in scope6.c
    ... On Tue, 9 Aug 2005, Bjoern A. Zeeb wrote: ... I think I found another problem with attach/detach in sk. ... retrieving revision 1.15 ...
    (freebsd-current)
  • Re: ethercons updated for -CURRENT
    ... On Sat, 10 Jul 2004, Bjoern A. Zeeb wrote: ... > It might be a bit linuxoid but I haven't checked the code yet. ... protocol is ... ...
    (freebsd-current)
  • Re: LOR g_xdown vs user map
    ... > Bjoern A. Zeeb wrote: ... > Yeah, I'm lazy, so I didn't do that. ...
    (freebsd-current)