Re: Panic in imo_match_source (netinet/in_mcast.c)

Hi,

I actually managed to get the same kernel dump using the following
sample code - http://people.freebsd.org/~syrinx/mcast/mcast_crash.c
and the crash is 100% reproducable. A temporary fix is here -
http://people.freebsd.org/~syrinx/mcast/in_mcast.c-20090908-01.diff
but I actually prefer that we go over the logic in inp_join_group()
again before proposing a patch for head as this is the second assert
panic I am seeing it causes in the last few days. I can try making up
a proper fix if Bruce is busy, but it will take a day or two until I'm
able to fully test it.

cheers,
Shteryana

On Tue, Sep 8, 2009 at 4:13 PM, Bruce Simpson<bms@xxxxxxxxxxxxxxx> wrote:
[Brief reply as I'm meant to be doing a zillion other things...]

Bruce Simpson wrote:

Full OS version, dmesg, panic and backtrace please, when reporting this
kind of issue... otherwise folk can't help. Are you using SSM multicast
features?

P.S. You might want to try demoting the KASSERT to a conditional error
return (return no match if src is NULL or src->sa_family != AF_INET), and
see if that fix 'just works' for you. Sometimes the asserts I sprinkle into
code are too paranoid for what's going on, and syrinx@ recently caught one
of those.

I can see some situations where this could kick off, so that is probably the
right fix. Please do let me know. If that fix works for you then it can
probably be checked in. There is an RC cutoff looming, so if I can't do it
in time, someone else may be able to check it in.

thanks,
BMS
_______________________________________________
freebsd-net@xxxxxxxxxxx mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-net
To unsubscribe, send any mail to "freebsd-net-unsubscribe@xxxxxxxxxxx"

_______________________________________________
freebsd-net@xxxxxxxxxxx mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-net
To unsubscribe, send any mail to "freebsd-net-unsubscribe@xxxxxxxxxxx"

Relevant Pages

  • Re: Web services XmlException
    ... I also have this same problem but haven't been able to locate a fix. ... I have another thread where I post some sample code where you can ... My last post in that thread says that sp2 ... >> The SOAP toolkit has a TraceUtility that works. ...
    (microsoft.public.dotnet.framework.compactframework)
  • Re: Icon on SubSubMenu
    ... I will be waiting until you fix it. ... > I was going to put a sample code to help you, but I have a better idea. ... >> Regards, ...
    (microsoft.public.vb.winapi)
  • Re: IMWSyncReader::Open()
    ... that all the sample code provided with both the 9.5 and 10.0 sdk give ... If you find any more information that can fix this before I do, ... Prev by Date: ...
    (microsoft.public.windowsmedia.sdk)
  • Re: MAPI Samples in Platform SDK
    ... again in a couple of days, maybe Microsoft will fix it permanently. ... sample code, or the EDK samples from: ...
    (microsoft.public.win32.programmer.messaging)
  • Re: Panic in imo_match_source (netinet/in_mcast.c)
    ... again before proposing a patch for head as this is the second assert ... a proper fix if Bruce is busy, but it will take a day or two until I'm ... The code in the start of inp_join_grouphandles all join requests, by mapping 3 possible sets of inbound ioctls onto 1, to make the ioctl processing code smaller. ... which is a bit more explicit. ...
    (freebsd-net)