Re: DANGER WILL ROBINSON! SERIOUS problem with current 5.4-PRERELEASE

From: Karl Denninger (karl_at_denninger.net)
Date: 03/30/05

  • Next message: Marc Olzheim: "Re: boot0: To beep or not to beep?" 
    Date: Wed, 30 Mar 2005 11:39:31 -0600
To: Jim Trigg <jtrigg@spamcop.net>

    On Wed, Mar 30, 2005 at 12:07:22PM -0500, Jim Trigg wrote:
    > On Wed, March 30, 2005 12:43 am, Karl Denninger said:
    > > Here's the diff and some thoughts....
    >
    > [snip, including first diff]
    >
    > > 241,243c244,249
    > > <
    > > < /* if reinit succeeded and retries still permit, reinject request
    > > */
    > > < if (ata_reinit(ch) && request->retries-- > 0 &&
    > > request->device->param){
    > > ---
    > >> /*
    > >> * if reinit succeeds, retries still permit and device didn't
    > >> * get removed by the reinit, reinject request
    > >> */
    > >> if (!ata_reinit(ch) && request->retries-- > 0
    > >> && request->device->param){
    > [snip third diff]
    >
    > > The second diff is really just a formatting and comment change.. you're
    > > certainly correct that the changes are small! :-)
    >
    > No, it is not -- it reverses the sense of the first condition. At first
    > glance that is what I would expect to be the core of the problem, but I
    > don't have appropriate hardware to test on. (It also adds a third
    > condition, but that is presumably the intent of the change and should give
    > the desired results once the first condition is corrected.)
    >
    > Jim
    > --
    > Jim Trigg, Lord High Everything Else O- /"\
    > Hostmaster, Huie Kin family website \ / ASCII RIBBON CAMPAIGN
    > Verger and System Administrator, X HELP CURE HTML MAIL
    > All Saints Church - Sharon Chapel / \

    You're correct of course - I missed the "!". Too darn late at night...

    I've got my sandbox up and the world rebuilt so its consistent with the
    machine that's having the problem - will add a SATA disk and see if I can
    duplicate this and then figure out what's going on here this afternoon -
    and hopefully how to fix it. 

    --
-- 
Karl Denninger (karl@denninger.net) Internet Consultant & Kids Rights Activist
http://www.denninger.net	My home on the net - links to everything I do!
http://scubaforum.org		Your UNCENSORED place to talk about DIVING!
http://www.spamcuda.net		SPAM FREE mailboxes - FREE FOR A LIMITED TIME!
http://genesis3.blogspot.com	Musings Of A Sentient Mind
_______________________________________________
freebsd-stable@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-stable
To unsubscribe, send any mail to "freebsd-stable-unsubscribe@freebsd.org"
  • Next message: Marc Olzheim: "Re: boot0: To beep or not to beep?"