Re: DANGER WILL ROBINSON! SERIOUS problem with current 5.4-PRERELEASE - UPDATE

From: Karl Denninger (karl_at_denninger.net)
Date: 03/31/05

  • Next message: Greg 'groggy' Lehey: "Re: Problems with AMD64 and 8 GB RAM?" 
    Date: Wed, 30 Mar 2005 21:08:30 -0600
To: "Matthew N. Dodd" <mdodd@freebsd.org>

    On Tue, Mar 29, 2005 at 11:43:18PM -0600, Karl Denninger wrote:
    > Here's the diff and some thoughts....
    >
    > Fs:/usr/src/sys/dev/ata> cvs diff -r 1.32.2.5 ata-queue.c
    > Index: ata-queue.c
    > ===================================================================
    > RCS file: /usr/cvs/src/sys/dev/ata/ata-queue.c,v
    > retrieving revision 1.32.2.5
    > retrieving revision 1.32.2.6
    > diff -r1.32.2.5 -r1.32.2.6
    > 30c30
    > < __FBSDID("$FreeBSD: src/sys/dev/ata/ata-queue.c,v 1.32.2.5 2004/10/24 09:27:37 sos Exp $");
    > ---
    > > __FBSDID("$FreeBSD: src/sys/dev/ata/ata-queue.c,v 1.32.2.6 2005/03/23 04:50:26 mdodd Exp $");
    > 218a219,221
    > > if (!dumping)
    > > callout_reset(&request->callout, request->timeout * hz,
    > > (timeout_t*)ata_timeout, request);
    > 241,243c244,249
    > <
    > < /* if reinit succeeded and retries still permit, reinject request */
    > < if (ata_reinit(ch) && request->retries-- > 0 && request->device->param){
    > ---
    > > /*
    > > * if reinit succeeds, retries still permit and device didn't
    > > * get removed by the reinit, reinject request
    > > */
    > > if (!ata_reinit(ch) && request->retries-- > 0
    > > && request->device->param){
    > 245a252
    > > request->donecount = 0;

    Removing the second change (changing the test on the "ata_reinit") appears to
    prevent both the destabilization and the actual requeue from taking place
    (that is, you get the immediate disconnect from the array when the error
    occurs; therefore whatever is causing the destabilization doesn't happen.)

    I will attempt to remove the first delta alone (and put back the second), but
    from a quick perusal of the code I doubt this will make a material change. 

    --
-- 
Karl Denninger (karl@denninger.net) Internet Consultant & Kids Rights Activist
http://www.denninger.net	My home on the net - links to everything I do!
http://scubaforum.org		Your UNCENSORED place to talk about DIVING!
http://www.spamcuda.net		SPAM FREE mailboxes - FREE FOR A LIMITED TIME!
http://genesis3.blogspot.com	Musings Of A Sentient Mind
_______________________________________________
freebsd-stable@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-stable
To unsubscribe, send any mail to "freebsd-stable-unsubscribe@freebsd.org"
  • Next message: Greg 'groggy' Lehey: "Re: Problems with AMD64 and 8 GB RAM?"