Re: mountd changed?



[Second attempt to send this, since my first seems to have been eaten by my
ISP. Apologies if it appears twice.]

On Sun, Oct 15, 2006 at 05:40:22PM +0200, Rink Springer wrote:
Hi,

On Sun, Oct 15, 2006 at 11:30:23PM +0800, Lin Jui-Nan Eric wrote:
Hi,

If I revert to revision 1.81.2.4, it worked correctly.

On 10/15/06, Rink Springer <rink@xxxxxxxxxxx> wrote:
Hi,

Hmm, I recently changed something which might trigger this. Could you
back out revision 1.81.2.5 of src/usr.sbin/mountd/mountd.c and let me
know whether this fixed the problem?


OK, could you try the attached patch (untested) and let me know whether
it works? (it patches the 1.81.2.5 revision of mountd.c)

I had the same problems, but only when trying to export directories from
the root filesystem. Your patch below would not help.
The following patch (very much inspired by the comment on line 1038 in
mountd.c) makes things work for me:

Index: mountd.c
===================================================================
RCS file: /ncvs/src/usr.sbin/mountd/mountd.c,v
retrieving revision 1.81.2.5
diff -u -r1.81.2.5 mountd.c
--- mountd.c 14 Oct 2006 23:04:07 -0000 1.81.2.5
+++ mountd.c 15 Oct 2006 21:09:20 -0000
@@ -1911,7 +1911,7 @@
iov[5].iov_base = fsb->f_mntfromname; /* "from" */
iov[5].iov_len = strlen(fsb->f_mntfromname) + 1;

- while (nmount(iov, iovlen, fsb->f_flags) < 0) {
+ while (nmount(iov, iovlen, fsb->f_flags & ~MNT_ROOTFS) < 0) {
if (cp)
*cp-- = savedc;
else






--- mountd.c.org Thu Sep 21 10:07:57 2006
+++ mountd.c Thu Sep 21 10:08:42 2006
@@ -1912,7 +1912,7 @@
iov[5].iov_base = fsb->f_mntfromname; /* "from" */
iov[5].iov_len = strlen(fsb->f_mntfromname) + 1;

- while (nmount(iov, iovlen, fsb->f_flags) < 0) {
+ while (nmount(iov, iovlen, fsb->f_flags | MNT_UPDATE) < 0) {
if (cp)
*cp-- = savedc;
else



--
<Insert your favourite quote here.>
Erik Trulsson
ertr1013@xxxxxxxxxxxxx

_______________________________________________
freebsd-stable@xxxxxxxxxxx mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-stable
To unsubscribe, send any mail to "freebsd-stable-unsubscribe@xxxxxxxxxxx"



Relevant Pages

  • Re: IPM.Post instead of IPM.Note (Exchange Server 2003)
    ... (Apologies for the repost - I types in "ms.p.e.application.conversion twice, ... > could you tell me is there a similar patch for Exchange ...
    (microsoft.public.exchange.admin)
  • Re: [revert] mysql+oltp regression
    ... During regression testing of tip/sched/clock fixes, a regression in low client count throughput turned up, which I traced this back to the commit below. ... We can re-try newer iterations of Greg's patch in tip/sched/devel. ... Now we are in the upstream release cycle so unless there's some immediate fix available (or there are _really_ strong reasons against the revert) doing the revert is the right approach. ...
    (Linux-Kernel)
  • Re: 2.6.19-rc3: known unfixed regressions (v3)
    ... Please revert the patch. ... I'm not sure reverting the patch solves the ACPI problem ... I think Jun'ichi is right - in your kernel, ...
    (Linux-Kernel)
  • Re: [PATCH][RSDL-mm 0/7] RSDL cpu scheduler for 2.6.21-rc3-mm2
    ... Gene Heskett wrote: ... than revert all the way, I just rebooted to 2.6.20.2-rdsl-0.30 and ... a patch, but who knows at this point, I'm not 'the shadow' in a 65 year ... but its also about 3 dumpcycles back and pretty much out of the picture ...
    (Linux-Kernel)
  • Re: mmotm 2009-09-03-16-35 uploaded
    ... Kamezawa-san's kcore patch series ... Can you post a .config, the vanilla dmesg, the dmesg with the page ... if neither of either revert, the system become hang before output any dmesg. ... is meant to change the pageblock ownership of each pageblock within a ...
    (Linux-Kernel)