Re: anyone that went through bsd.port.mk ?

From: Conrad J. Sabatier (conrads_at_cox.net)
Date: 10/18/04 

Date: Mon, 18 Oct 2004 18:41:08 GMT

In article <ay655818rj.fsf@bsdclient1.pipemedia.net>,
Justins local account <justin-nntp@pipemedia.net> wrote:
>
>
>jimjim <freebsd_net@blueyonder.co.uk> writes:
>
>> Hello,
>>
>> I posted the same question on freebsd.ports, but nobody replied. Please do
>> offer some insight.
>> I have made the following modifications to the bsd.port.mk Makefile for
>> learning purposes:
>>
>> # Main logic. The loop generates 6 main targets and using cookies
>> # ensures that those already completed are skipped.
>> .for target in extract patch configure build install package
>>
>> .if !target(${target}) && defined(_OPTIONS_OK)
>>          @${ECHO_MSG} "COOKIE WAS MADE FOR TARGET ${target}" //ADDED BY ME
>> ${target}: ${${target:U}_COOKIE}
>> .elif !target(${target})
>>          @${ECHO_MSG} "CONGIG WAS MADE FOR TARGET ${target}" //ADDED BY ME
>> ${target}: config
>>         @cd ${.CURDIR} && ${MAKE} CONFIG_DONE=1 
>> ${__softMAKEFLAGS}${${target:U}_COOKIE}
>> .elif target(${target}) && defined(IGNORE)
>> .endif
>
>just from a quick skim, shouldn't it be:
>
> .if !target(${target}) && defined(_OPTIONS_OK)
> ${target}: ${${target:U}_COOKIE}
>          @${ECHO_MSG} "COOKIE WAS MADE FOR TARGET ${target}" //ADDED BY ME
> .elif !target(${target})
> ${target}: config
>         @${ECHO_MSG} "CONGIG WAS MADE FOR TARGET ${target}" //ADDED BY ME
>         @cd ${.CURDIR} && ${MAKE} CONFIG_DONE=1 
> ${__softMAKEFLAGS}${${target:U}_COOKIE}
> .elif target(${target}) && defined(IGNORE)
> .endif
>
>--
>Justin Murdock

And shouldn't it be "CONFIG", not "CONGIG"? :-) 

-- 
Conrad J. Sabatier <conrads@cox.net> -- "In Unix veritas"